I want to download the eclair's source code ............but when i write:
repo init -u git://github.com/cyanogen/android.git -b eclair
i reiceive the error message:
command not found
why?
87Fra87 said:
I want to download the eclair's source code ............but when i write:
repo init -u git://github.com/cyanogen/android.git -b eclair
i reiceive the error message:
command not found
why?
Click to expand...
Click to collapse
Try here
http://wiki.cyanogenmod.com/index.php/Building_from_source
u dont have anything installed in ur machine first do this
1.sudo aptitude install git-core gnupg sun-java5-jdk flex bison gperf libsdl-dev libesd0-dev libwxgtk2.6-dev build-essential zip curl libncurses5-dev zlib1g-dev
then install the command repo
cd ~
mkdir bin
cd bin
echo $PATH
curl http://android.git.kernel.org/repo >~/bin/repo
chmod +x ~/bin/repo
u actually need the curl command for installing repo command but the commands i posted are need if u wanna build a rom
anyways i have posted the instructions in my thread, if u follow them u will not have any problem
87Fra87 said:
I want to download the eclair's source code ............but when i write:
repo init -u git://github.com/cyanogen/android.git -b eclair
i reiceive the error message:
command not found
why?
Click to expand...
Click to collapse
If you have done everything indicated on source.android.com/download, then restart your machine it will solve the problem.
Related
Due to frequent loss of net connection in my home country
Can someone be kind enough to provide me a link to the complete android source code for froyo
That you get on using the command
repo init -u git://anroid .....
repo sync
Any source above donut will do
and any server like megaupload , mediafire , 4shared anything will do
If any one willing to do it and do not know
Here enter these lines in Linux terminal
$ sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu dapper main multiverse"
$ sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu dapper-updates main multiverse"
$ sudo apt-get update
$ sudo apt-get install sun-java5-jdk
$ sudo apt-get install git-core gnupg flex bison gperf build-essential \
zip curl zlib1g-dev libc6-dev lib32ncurses5-dev ia32-libs \
x11proto-core-dev libx11-dev lib32readline5-dev lib32z-dev \
libgl1-mesa-dev g++-multilib mingw32 tofrodos
$ mkdir ~/bin
$ PATH=~/bin:$PATH
$ curl https://android.git.kernel.org/repo > ~/bin/repo
$ chmod a+x ~/bin/repo
$ mkdir WORKING_DIRECTORY
$ cd WORKING_DIRECTORY
$ repo init -u git://android.git.kernel.org/platform/ma…
$ repo init -u git://android.git.kernel.org/platform/ma… -b froyo
$ repo sync
Just rar the WORKING_Directory and upload it please
Or just send a link if u have one
THank you very much
Does know one care ??
Well even gingerbread will do !
atleast give me some hopes that people are downloading it
vious22 said:
Does know one care ??
Well even gingerbread will do !
atleast give me some hopes that people are downloading it
Click to expand...
Click to collapse
No one will help you?
Ok I can go to me PC and do that for you if you still need that
Sent from my X10i using XDA App
It would be really nice of you if u did that
please help me
You can help me by downloading either
1.Cyanogenmod 6
2.Cyanogenmod 7
3.AOSP Eclair
4.AOSP Froyo
5.AOSP Gingerbread
I will make the ROM whicher you provide me
And I will give you a script just make it executable and run it in terminal
Thank you very much
Ok. FROYO Ready
Sent from my X10i using XDA App
Ok pm to me your script
P.S. AOSP FROYO = froyo-plus-aosp ?
Sent from my X10i using XDA App
No and
Can u get python on your Linux comp first
U can run the script only after that
Sent from my HTC Desire S using XDA App
OK wear the script ?
Or tel me more what you need
I heave now Froyo and Gingerbred
(repo init -u git://android.git.kern… -b froyo ) 7-zip archive 2.5 GB (2737951464 bytes)
(repo init -u git://android.git.kern… -b gingerbred ) 7-zip archive 3.8 GB (4108073613 bytes)
I can upload that to ftp IF YOU NEED
P.S. python / linux and bla bla bla are READY !!!
I'm about to cry ....
Can u upload gingerbread please
And thanx a ton
Sent from my HTC Desire S using XDA App
This is Gingerbred git from google 30/06/2011 (x10-*.* it not means that are optimized for X10 its are for X10 project )
Download x10-Gingerbred.part01.rar ... (9 files in one place )
OR
x10-Gingerbred.part01.rar - 500mb
x10-Gingerbred.part02.rar - 500mb
x10-Gingerbred.part03.rar - 500mb
x10-Gingerbred.part04.rar - 500mb
x10-Gingerbred.part05.rar - 500mb
x10-Gingerbred.part06.rar - 500mb
x10-Gingerbred.part07.rar - 500mb
x10-Gingerbred.part08.rar - 500mb
x10-Gingerbred.part09.rar - 234MB
Hello Experienced Cooper users
today i shall guide you to compile ur own Cyanogenmod rom
ive adapted this guide to work for cooper
and removed some useless parts wich i self didnt used and still compiled succesfull rom
U MUST RUN A LINUX DISTRO
ok we shall begin now:
1. making the correct directory's
Code:
cd~
mkdir android
mkdir cyanogenmod7
those are the 2 main directorys i will use Note* remember each command is 1 line
Installing Java6 (JDK)
in terminal type / copy paste from here
Code:
sudo add-apt-repository ppa:ferramroberto/java
sudo apt-get update
sudo apt-get install sun-java6-jdk
Install Required dependencies/add-ons
32 bit Linux Mint 14
Code:
sudo apt-get install git-core gnupg flex bison gperf libsdl-dev libesd0-dev libwxgtk2.6-dev build-essential zip curl libncurses5-dev zlib1g-dev pngcrush schedtool
copy and paste it all in terminal
64 bit Linux Mint 14
Code:
sudo apt-get install git-core gnupg flex bison gperf libsdl-dev libesd0-dev libwxgtk2.6-dev build-essential zip curl libncurses5-dev zlib1g-dev valgrind lib32readline-gplv2-dev gcc-multilib g++-multilib libc6-dev-i386 lib32ncurses5-dev ia32-libs x11proto-core-dev libx11-dev lib32z-dev pngcrush schedtool
copy and paste it all in terminal
Synching the Source Code of CM7
Code:
cd ~
mkdir bin
paste/type those lines in terminal
now type/paste this in terminal and REBOOT SYSTEM
Code:
curl https://dl-ssl.google.com/dl/googlesource/git-repo/repo > ~/bin/repo
chmod a+x ~/bin/repo
after reboot u can use the Repo Commands
now cd to ur directory we created in the begin
first do
Code:
cd~
then do
Code:
cd android/cyanogenmod7
once done that initialize repo
paste/type this in terminal
Code:
repo init -u git://github.com/CyanogenMod/android.git -b gingerbread
Note: if you wanna have a smaller download and only download specific sources for Cooper try to sync my moddified and reduced repo this still is cm but will not sync all the extra useless files then sync
Code:
repo init -u git://github.com/spacecaker/android_cooper.git -b gingerbread
and do
Code:
repo sync -j4
now u will need to wait
this will sync the approx 10/15 GB source codes
takes about 1/10 hours to sync depending on connection
now lets sync our device configs
once everything has been synched and still in the
Code:
cd android/cyanogenmod7
directory
type
Code:
cd device
mkdir samsung
cd samsung
now
type/paste
Code:
git clone https://github.com/vo-1/android_device_samsung_cooper cooper
once that is synched
do to go to the the root of Cyanogenmod7 directory
Code:
cd ..
cd ..
now we will get the vendor of our cooper device
do type/paste in terminal
Code:
cd vendor
mkdir samsung
cd samsung
and sync the cooper vendor
Code:
git clone https://github.com/vo-1/android_vendor_samsung_cooper cooper
now do
Code:
cd ..
and type
Code:
~/android/cyanogenmod7/vendor/cyanogen/get-rommanager
now lets build
this is how i personally build it on my way but takes more time
i will tell u first my way then original way
do type/paste in terminal
Code:
. build/envsetup.sh
Code:
brunch cooper
then it will compile it and make a zip file for you aswell wich is findable in out folder
Note it takes long time
or do
Code:
lunch cm_cooper-eng
make -j4 bacon
what did i skip ?
i personally skipped ADB and SDK because i run Linux in a Virtual machine
Hope you guys will enjoy this guide
Special thanks to
Vo-1
dastin1015 <- for some basic parts of the guide
if ive missed a part / have isseus with my grammar
do notice me
Sent from my S500 using xda app-developers app
Nice one you really deserve a recognized contributor title dude!
From Gingerbread you need a 64-bit environment to compile succesfully Android. You can remove the part of guide about 32 bit
Paolo_lav said:
From Gingerbread you need a 64-bit environment to compile succesfully Android. You can remove the part of guide about 32 bit
Click to expand...
Click to collapse
for gingerbread 32 bit can be used
also for JB and ICS
but for JB u need to sync extra file
Sent from my S500 using xda app-developers app
Nowhere it is said that you will need Linux. Great guide though. :good:
At the moment I am thinking about some people trying to get sudo to work on their Windows machines.
nikwen said:
Nowhere it is said that you will need Linux. Great guide though. :good:
At the moment I am thinking about some people trying to get sudo to work on their Windows machines.
Click to expand...
Click to collapse
last part i said i run linux in vm
but will add
Sent from my S500 using xda app-developers app
Added a Slimmed Down Repo for Cooper only
wich will sync the device and vendr sources of cooper only and not all the useless stuff
OK,thank you .maybe I will fello you to make a rom,somedays.
Sent from my GT-S5830 using xda app-developers app
@SpaceCaker Bro, PPA No longer exists... Please update the OP with the commands that work.. It has been updated few days ago...
agosain7 said:
@SpaceCaker Bro, PPA No longer exists... Please update the OP with the commands that work.. It has been updated few days ago...
Click to expand...
Click to collapse
i searched a lot on google forbfixed java command
and if u remove the error stop command
you can compile it aswell
Sent from my S500 using xda app-developers app
Building on Ubuntu 12.04 is currently only experimentally supported and is not guaranteed to work on branches other than master.
Installing required packages (Ubuntu 12.04)
Code:
$ sudo apt-get install git gnupg flex bison gperf build-essential \
zip curl libc6-dev libncurses5-dev:i386 x11proto-core-dev \
libx11-dev:i386 libreadline6-dev:i386 libgl1-mesa-glx:i386 \
libgl1-mesa-dev g++-multilib mingw32 tofrodos \
python-markdown libxml2-utils xsltproc zlib1g-dev:i386
$ sudo ln -s /usr/lib/i386-linux-gnu/mesa/libGL.so.1 /usr/lib/i386-linux-gnu/libGL.so
Installing Repo
Code:
$ mkdir ~/bin
$ PATH=~/bin:$PATH
Code:
$ curl https://dl-ssl.google.com/dl/googlesource/git-repo/repo > ~/bin/repo
$ chmod a+x ~/bin/repo
Now 80% of your work is done.. Now its time for actual cm10.2 development
Code:
mkdir -p cm10.2
Code:
$ PATH=~/bin:$PATH
Code:
cd cm10.2
Code:
repo init -u git://github.com/androidarmv6/android.git -b cm-10.2
Code:
repo sync -jX
where X is any integer. If you have high speed connection then try something like -j16 or -j32
This will take long time because you are trying to download around 15gb
Once this is done go in your cm10.2 directory and do this
Code:
sh vendor/cm/get-prebuilts
Congrats your build machine is now ready.
Create a script named " compile.sh " inside cm10.2 folder and paste these contents inside it.
Code:
#!/system/bin/sh
PATH=~/bin:$PATH
repo sync -j32
.build/envsetup.sh
export USE_CCACHE=1
make clean
brunch protou
So to start compiling you have to do this command inside your cm10.2 folder
Code:
sh compile.sh
This will give you a basic build machine. I haven't added the device specific stuff yet. To do that:
Assuming you are in cm10.2 folder before each step.
1.Create device tree
Code:
mkdir -p /device/htc
Go in /device/htc
Code:
git clone https://github.com/prototype-U/android_device_htc_protou.git
Rename this folder to protou
Code:
git clone https://github.com/ProtouProject/android_device_htc_common.git
Rename this folder to common
2.Add vendors WIP
Code:
mkdir -p /vendor/htc/
Go in /vendor/htc/
Code:
git clone https://github.com/prototype-U/android_vendor_htc_protou.git
Rename this folder to protou
3.Add kernel sources
Code:
mkdir -p kernel/htc/
Go in /kernel/htc/protou
Code:
git clone -b cm10.2 https://github.com/prototype-U/android_kernel_htc_protou.git
Rename this folder to protou
And you are done! You can try compiling now..
I'll try this on Arch Linux in the evening and report back if it worked. Hopefully I'll find the right dependencies for the build as Arch Linux is a bit special with this. Anyway thanks for the guide!
Sent from my HTC Desire X using XDA Premium 4 mobile app
Why?
repo init -u git://github.com/androidarmv6/android.git -b cm-10.2
we got ARMv7
Klapo said:
Why?
repo init -u git://github.com/androidarmv6/android.git -b cm-10.2
we got ARMv7
Click to expand...
Click to collapse
Source, Its on androidarmv6 git its a group or something...not related to this.
Sent from my HTC Desire X using xda premium
Found a typo. It has to be "-b cm-10.2" in last clone command, then it works.
prototype-U said:
Create a script named " compile.sh " inside cm10.2 folder and paste these contents inside it.
Code:
#!/system/bin/sh
PATH=~/bin:$PATH
repo sync -j32
.build/envsetup.sh
export USE_CCACHE=1
make clean
brunch protou
So to start compiling you have to do this command inside your cm10.2 folder
Code:
sh compile.sh
Click to expand...
Click to collapse
A guy from #cyanogenmod-dev told me that is much better to use terminal to start compiling then this script,he told me to do this :
cd cm10.2
export USE_CCACHE=1
source build/envsetup.sh
brunch protou
These are just recommendations.
prototype-U said:
Code:
mkdir -p /device/htc
Go in /device/htc
Click to expand...
Click to collapse
It's actually mkdir -p device/htc. You made a typo,it will create a folder inside the system partition.
Then go into device/htc.
prototype-U said:
Code:
mkdir -p /vendor/htc/
Go in /vendor/htc/
Click to expand...
Click to collapse
Same here,it's mkdir -p vendor/htc .
Then go in vendor/htc.
prototype-U said:
Code:
mkdir -p kernel/htc/
Go in /kernel/htc/protou
Click to expand...
Click to collapse
The folder location is good here but you go :
cd kernel/htc instead of /kernel/htc/protou.
Also i had to install these to make it work. We need java,etc.
Code:
git-core gnupg flex bison gperf libsdl1.2-dev libesd0-dev libwxgtk2.8-dev squashfs-tools build-essential zip curl libncurses5-dev zlib1g-dev openjdk-6-jre openjdk-6-jdk pngcrush schedtool libxml2 libxml2-utils xsltproc
Code:
g++-multilib lib32z1-dev lib32ncurses5-dev lib32readline-gplv2-dev gcc-multilib
Don't take this offensively,i am just trying to help.
nightwalkerkg said:
A guy from #cyanogenmod-dev told me that is much better to use terminal to start compiling then this script,he told me to do this :
cd cm10.2
export USE_CCACHE=1
source build/envsetup.sh
brunch protou
These are just recommendations.
It's actually mkdir -p device/htc. You made a typo,it will create a folder inside the system partition.
Then go into device/htc.
Same here,it's mkdir -p vendor/htc .
Then go in vendor/htc.
The folder location is good here but you go :
cd kernel/htc instead of /kernel/htc/protou.
Also i had to install these to make it work. We need java,etc.
Code:
git-core gnupg flex bison gperf libsdl1.2-dev libesd0-dev libwxgtk2.8-dev squashfs-tools build-essential zip curl libncurses5-dev zlib1g-dev openjdk-6-jre openjdk-6-jdk pngcrush schedtool libxml2 libxml2-utils xsltproc
Code:
g++-multilib lib32z1-dev lib32ncurses5-dev lib32readline-gplv2-dev gcc-multilib
Don't take this offensively,i am just trying to help.
Click to expand...
Click to collapse
None taken. To be honest I have never tried setting up a build machine because my build server already had everything installed. And the steps I have mentioned above are not tested by me. I modify the core manifest to sync everything rather than doing it manually. Btw there is nothing wrong with the script, I made it just to reduce my manual work.
Sent from my HTC Desire X using xda app-developers app
I ran into problems using the script, because I use zsh as my favorite shell. When the shell interpreter used in the script and the shell used for building is not the same, the sourcing won't work and it will give you an error like "brunch: command not found".
dansou901 said:
I ran into problems using the script, because I use zsh as my favorite shell. When the shell interpreter used in the script and the shell used for building is not the same, the sourcing won't work and it will give you an error like "brunch: command not found".
Click to expand...
Click to collapse
You have to make sure that you have synced all device related repos correctly. To make sure; goto the folder where you synced; goto device/htc and you should see protou and common folders.
dansou901 said:
I ran into problems using the script, because I use zsh as my favorite shell. When the shell interpreter used in the script and the shell used for building is not the same, the sourcing won't work and it will give you an error like "brunch: command not found".
Click to expand...
Click to collapse
Do it each time in a new shell. . /build/envsetup.sh
Sent from my HTC Desire X using xda app-developers app
Instead of renaming we could do
git clone git://github.com/<user>/android_device_htc_protou.git protou
do the same for common
Just a suggestion (sames lot of time :silly: )
I would like to have more roms for this device and guide how to make rom based on my source/work
Note: There is no need to credit me , but yeah i will admire if you mention me for this
SO before we start lets get some things cleared
You have quad core CPU
You have atleast 4GB ram
Stable Internet
Linux Installed ( I am using ubuntu 14.04 LTS)
Brain.apk
Getting started
Installing the required packages
Easy just open a terminal.
Code:
sudo apt-get install git-core gnupg flex bison gperf build-essential \
zip curl zlib1g-dev gcc-multilib g++-multilib libc6-dev-i386 \
lib32ncurses5-dev x11proto-core-dev libx11-dev lib32z-dev ccache \
libgl1-mesa-dev libxml2-utils xsltproc unzip
Installing JAVA
Code:
sudo apt-get update
sudo apt-get install openjdk-7-jdk
Getting ready with repo
Code:
mkdir ~/bin && PATH=~/bin:$PATH && echo 'PATH=~/bin:$PATH' >> ~/.bashrc && curl https://storage.googleapis.com/git-repo-downloads/repo > ~/bin/repo && chmod a+x ~/bin/repo
Settings up the GIT
Before doing the below step head over to github.com and make a git account
Code:
git config --global user.name "Your Name"
git config --global user.email "[email protected]"
Making CyanogeMod 12.1
First we will make a folder where we can hold our repos and source codes
Code:
mkdir ~/cm-12.1/
Now we will sync the cm sources.. depending on your internet speed it may take mins , hours and days. (for me 30 to 60 mins)
Code:
cd ~/cm-12.1/ && repo init -u https://github.com/CyanogenMod/android.git -b cm-12.1
repo sync -j4
Getting note 3 neo codes, vendor and etc
Code:
cd ~/cm-12.1/ && git clone https://github.com/FireLord1/android_.repo_local_manifests_n3n.git -b cm-12.1 .repo/local_manifests
repo sync -j4 --force-sync
Building the ROM
Code:
cd ~/cm-12.1
source build/envsetup.sh
lunch (now select your device 3g is hl3g and 4g is hllte and select userdebug)
brunch (your device codename like cm_hl3g-userdebug)
Thats all for now if you face any error try googling the dev is not free man!
Thank U fire lord U can do anything thanks For showing interest on our device
nice thank you very much for this
but i hate ubuntu's terminal , no ctrl+c, ctrl+v -.-
EDit
bash: /home/berk/bin/repo: Permission denied
i get this error when i setup the repo before downloading
Any help? @FireLord
TimurAlaskara_TR said:
nice thank you very much for this
but i hate ubuntu's terminal , no ctrl+c, ctrl+v -.-
EDit
bash: /home/berk/bin/repo: Permission denied
i get this error when i setup the repo before downloading
Any help? @FireLord
Click to expand...
Click to collapse
Try doing in superuser mode
Code:
sudo su
Sent from FireLord's device
Actually I have read so many topics about building Android Open Source Project for Intel based platform , they are such Android X86 , OS Remix and AOSP_IA (AOSP for Intel Architecture).
Now I want to build an AOSP for my tablet which is based on Intel Atom ( Z3735F), 10.1 inches display , 2 GB RAM and INSYDE UEFI bios type , device codename :inet_phone_32
My tablet runs Android 5.1.1_r1 (AOSP_AI TYPE) , there is no back up or rooting technique for this tablet ,so I decide to build an AOSP ROM for this tablet ,if the Android OS has a problem , I am able to flash it again and survive it.
I have tried in 3 ways to build an AOSP for my tablet but no one is correct so, I need an android developer or android expert to guide me and modify my mistakes .
According to google source :
these are steps for building AOSP for a device :
1. install , Java 8 ,git, curl , ($ sudo apt-get install "App")
2. Setting up ccache
3. install repo
$ mkdir ~/bin
$ PATH=~/bin:$PATH
$ curl https://storage.googleapis.com/git-repo-downloads/repo > ~/bin/repo
$ chmod a+x ~/bin/repo
4. creating working Directory
$ mkdir WORKING_DIRECTORY
$ cd WORKING_DIRECTORY
5.git configuration (name and email)
$ git config --global user.name "Your Name"
$ git config --global user.email "[email protected]"
6.inititilized repo and download the proper ROM
$ repo init -u https://android.googlesource.com/platform/manifest
$ repo init -u https://android.googlesource.com/platform/manifest -b android-5.1.1_r1
$ repo sync
7.$ . build/envsetup.sh
8. choosing the target
$ lunch inet_phone_32-userdebug
9.$ make(m) -j4-efi
Click to expand...
Click to collapse
unfortunately , it wont flash on my tablet !
According to Android X86 : these are steps for building an AOSP_X86
1. install , Java 8 ,git, curl , ($ sudo apt-get install "App")
2. Setting up ccache
3. install repo
$ mkdir ~/bin
$ PATH=~/bin:$PATH
$ curl https://storage.googleapis.com/git-repo-downloads/repo > ~/bin/repo
$ chmod a+x ~/bin/repo
4. creating working Directory
$ mkdir WORKING_DIRECTORY
$ cd WORKING_DIRECTORY
5.git configuration (name and email)
$ git config --global user.name "Your Name"
$ git config --global user.email "[email protected]"
6.inititilized repo and download the proper ROM
$ repo init -u http://scm.osdn.net/gitroot/android-x86/manifest
$ repo init -u http://scm.osdn.net/gitroot/android-x86/manifest -b lollipop-x86
$ repo sync --no-tags --no-clone-bundle
7.$ . build/envsetup.sh
8. choosing the target
as it was said on Android X86 instruction :
$ lunch android_x86-userdebug
9.$ make(m) -j4-efi
Click to expand...
Click to collapse
unfortunately , it also wont flash on my tablet !
According to Android on Intel Platform , these are below steps for building AOSP_IA:
Dependencies:
Follow initial steps from here: https://source.android.com/source/initializing.html
Additional Dependencies:
sudo apt-get install git-core gnupg flex bison gperf build-essential lunch zip curl zlib1g-dev gcc-multilib g++-multilib libc6-dev-i386 lib32ncurses5-dev x11proto-core-dev libx11-dev lib32z-dev ccache libgl1-mesa-dev libxml2-utils xsltproc unzip squashfs-tools python-mako distcc ccache python2.7 python-mako gettext mtools qt-sdk
Additional packages to be installed when developing in a Ubuntu chroot environment (created with debootstrap):
bc, dosfstools, mtools, libssl-dev
Github Account and SSH Keys:
Ensure you have your ssh key setup with your Github account:
https://help.github.com/articles/generating-an-ssh-key/
https://help.github.com/articles/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent/
https://help.github.com/articles/adding-a-new-ssh-key-to-your-github-account/
Setup CCache (Speeds up compilation):
https://source.android.com/source/initializing.html#setting-up-ccache
Downloading the source code
Using SSH protocol:
repo init -u [email protected]:android-ia/manifest.git
If you prefer using https:
repo init -u https://github.com/android-ia/manifest.git
Sync Code
repo sync
Building the OS image
. build/envsetup.sh
lunch androidia_64-eng
m -j4 android_ia-efi
Flash Image:
Unmount USB: sudo umount /dev/sdg* (Check where usb is mounted and change appropriately)
Flash the image: sudo dd if=out/target/product/androidia_64/androidia_64.img of=/dev/sdg (Check where usb is mounted and change appropriately)
Click to expand...
Click to collapse
which is not flashing on my tablet
Please kindly help me where are my mistakes , how can I modify it , if I dont know missing information , please contribute ,thank you