[MOD][GUIDE][HOW-TO][Lollipop]Fix email body RTL alignment for Samsung Email client - Galaxy Note 4 Android Development (Snapdragon)

Hello guys!
Since the update for lollipop started rolling out for Samsing devices, we have noticed that the RTL alignment of the email content in the Samsung Email client is no longer responsive to the csc feature we had used before. On builds up untill kitkat it was enough to add the following line <CscFeature_Email_AlignmentForRTL>true</CscFeature_Email_AlignmentForRTL> to the csc feature set and all would miraculously be OK. On Lollipop the method which sets the message layout direction (makeNewBodyContents4RTL) no longer responds to CSC feature, rendering that feature a dead stick method.
On new lollipop build for Note 4 and Note edge we have a different condition for proper message RTL alignment and that condition is setting the system to one of the RTL languages. Since some people prefer to use their device in English or other LTR language, this option is not always appealing to them. So here goes the fix. Now you can provide your users with an option to have RTL alignment in any system language. This will only affect RTL text. No worries for the LTR users.
Navigate to /smali/com/android/email/activity/MessageCompose.smali and search for the following code:
Code:
invoke-static {}, Lcom/android/email/util/EmailFeature;->isRTLLanguage()Z
move-result v11
if-nez v11, :cond_a
This is the one place in this method that checks if the system language is one of the RTL languages (Arabic, Hebrew, Farsi...) and according to that invokes method makeNewBodyContents4RTL().
So lets see the logic. If the user is using their phone in Arabic, this will invoke a boolean isRTLLanguage() in EmailFeature.class. That boolean will return TRUE for Arabic and therefore register V11 will get a value of 1. The condition states that if V11 is not equal to zero (and it is not, since it is 1), then use cond_a. Following down the line we can see that cond_a is invoking a method called makeNewBodyContents4RTL(). Which produces RTL aligned mail message if the FIRST CHAR (first letter) is in RTL language. So no worries for the LTR users.
So... if the user is using their phone in Italian (f.e...) the boolean isRTLLanguage() will return FALSE (0). So there will be no RTL alignment of the mail.
So what we will do is feed TRUE in ANY case to the V11 register. Like so. You need to add the line in blue:
Code:
invoke-static {}, Lcom/android/email/util/EmailFeature;->isRTLLanguage()Z
move-result v11
[COLOR="Blue"]const/16 v11, 0x1[/COLOR]
if-nez v11, :cond_a
That's it. You can also remove the line with invoke-static and move-result and just put const/16 v11, 0x1 instead. It doesn't matter how you do it. As long is that register gets 1 and not 0 under all conditions.
DO NOT change the conditions of the boolean isRTLLanguage() in EmailFeature.class because you will end up with ALOT of layout troubles in LTR languages. What the user needs is ONLY the RTL alignment for the body of the Email. So we solve it in the class that uses that method and NOT in the class that provides the boolean for a bunch of other classes in the app.
Cheers guys!
This thread is among other things dedicated to my friend @DaOldMan and his friend Bullmans (Shuchi) who have been struggling with this feature for a while now. Love you guys, you can move on now

---

As always , you the best ! Regards Anna :fingers-crossed:

---

Perfect!!
thank you very much my dear.

---

bonboni said:
Perfect!!
thank you very much my dear.
Click to expand...
Click to collapse
What a username, my friend . ... I keep forgetting it's you when I see it and it takes me a while to remember! lol!!! You're welcome!!!
Sent from my SM-G900F using Tapatalk

---

Thanks a lot for the dedication @daxgirl . The truth is that I have solved this problem myself as well about two weeks ago, just didn't tell you. My mod is a bit different (but does mostly the same). I also fed TRUE to two other method calls a bit later on. Just to be on the safe side . Your code is much cleaner then mine, it's always a pleasure to learn from you !
Code:
invoke-static {}, Lcom/android/email/util/EmailFeature;->isRTLLanguage()Z
move-result v6
# This goto forces RTL even if the method "isRTLLanguage" returned a result that the locale is not RTL. Was a "if" to use RTL only if the locale is RTL - Thomas
goto :cond_a
iget-object v6, p0, Lcom/android/email/activity/MessageCompose;->mOriginalBody:Lcom/android/email/htmleditor/HtmlEditingView;
# This goto forces RTL even if the method "isRTLLanguage" returned a result that the locale is not RTL. Was a "if" to use RTL only if the locale is RTL - Thomas
goto :cond_a
iget-boolean v6, p0, Lcom/android/email/activity/MessageCompose;->mIsOriginMsgEdited:Z
# This goto forces RTL even if the method "isRTLLanguage" returned a result that the locale is not RTL. Was a "if" to use RTL only if the locale is RTL - Thomas
goto :cond_a
invoke-direct {p0}, Lcom/android/email/activity/MessageCompose;->makeOriginalBodyContents4RTL()V
:cond_a
invoke-virtual {v0}, Lcom/android/emailcommon/provider/EmailContent$Account;->getEmailAddress()Ljava/lang/String;
then later on:
Code:
invoke-static {}, Lcom/android/email/util/EmailFeature;->isRTLLanguage()Z
move-result v5
# This goto forces RTL even if the method "isRTLLanguage" returned a result that the locale is not RTL. Was a "if" to use RTL only if the locale is RTL - Thomas
goto :cond_2
iget-object v5, p0, Lcom/android/email/activity/MessageCompose;->mRichToolbar:Lcom/android/email/activity/ToolBarView;
invoke-virtual {v5}, Lcom/android/email/activity/ToolBarView;->getLayoutParamsOfFontsizeTextView()Landroid/view/ViewGroup$LayoutParams;
move-result-object v5
iget v5, v5, Landroid/view/ViewGroup$LayoutParams;->width:I
and finaly:
Code:
invoke-static {}, Lcom/android/email/util/EmailFeature;->isRTLLanguage()Z
move-result v11
# This goto forces RTL even if the method "isRTLLanguage" returned a result that the locale is not RTL. Was a "if" to use RTL only if the locale is RTL - Thomas
goto :cond_a
move-object/from16 v0, p0
iget-object v11, v0, Lcom/android/email/activity/MessageCompose;->mWebHTMLMarkupData_NewBody:Lcom/android/email/htmleditor/HtmlEditingView$WebHTMLMarkupData;
invoke-virtual {v11}, Lcom/android/email/htmleditor/HtmlEditingView$WebHTMLMarkupData;->htmlFragment()Ljava/lang/String;

---

@daxgirl thanks a mill for another great mod.
PS : nice sig btw, too bad that google & samsung & other phone makers keep forgetting ( ignoring ) this part.

---

claude96 said:
@daxgirl thanks a mill for another great mod.
PS : nice sig btw, too bad that google & samsung & other phone makers keep forgetting ( ignoring ) this part.
Click to expand...
Click to collapse
My pleasure!
And yes, it's very true. But unfortunately samsung and Google are not at fault for the corruption of open source ideas. Xda is.
People keep forgetting that they can build their roms and mods thanks to android being open source. Open source doesn't mean "for free". Yiu can sell open source. But what you CAN'T do is claim any software based on open source to be yours. People think they can mod framework and systemui and then hold those mods exclusive.
Nothing belongs to anyone in open source. It's public property. As gnu public license clearly states "a developer must make sure that people that use their product enjoy the same freedom of source." Open source based mods belong to the world. And the source MUST be made available. And if people want credits they should annotate their code inside. No one has the right to demand to be asked for permission. Giving credit is a politeness thing. It's like saying thank you. But no android rom is exclusive. And all code should be made available.

---

daxgirl said:
My pleasure!
And yes, it's very true. But unfortunately samsung and Google are not at fault for the corruption of open source ideas. Xda is.
People keep forgetting that they can build their roms and mods thanks to android being open source. Open source doesn't mean "for free". Yiu can sell open source. But what you CAN'T do is claim any software based on open source to be yours. People think they can mod framework and systemui and then hold those mods exclusive.
Nothing belongs to anyone in open source. It's public property. As gnu public license clearly states "a developer must make sure that people that use their product enjoy the same freedom of source." Open source based mods belong to the world. And the source MUST be made available. And if people want credits they should annotate their code inside. No one has the right to demand to be asked for permission. Giving credit is a politeness thing. It's like saying thank you. But no android rom is exclusive. And all code should be made available.
Click to expand...
Click to collapse
@daxgirl Again thanks a million ton.
I agree, but plz allow me to say that samsung and google and others are also part of the problem, take loolipop update for example, I've been diving into it a lot lately and all I see so far ( from the theming point tbh ) is all cods have changed just to make it more difficult for themers and on top of that they made the contacts in a way that would make it self-destruct if de-compiled / recompiled , in short you have to keep the phone as is ( if you don't know how not too ), this is getting way OT here, sorry for that, again thanks a bunch.
PS : can I pm you !, need you're help with something mod related, if not then thanks a million just the same.

---

another excellent Guide/mod @daxgirl. I really admire your work. Thanks a lot.

---

claude96 said:
@daxgirl Again thanks a million ton.
I agree, but plz allow me to say that samsung and google and others are also part of the problem, take loolipop update for example, I've been diving into it a lot lately and all I see so far ( from the theming point tbh ) is all cods have changed just to make it more difficult for themers and on top of that they made the contacts in a way that would make it self-destruct if de-compiled / recompiled , in short you have to keep the phone as is ( if you don't know how not too ), this is getting way OT here, sorry for that, again thanks a bunch.
PS : can I pm you !, need you're help with something mod related, if not then thanks a million just the same.
Click to expand...
Click to collapse
Hey. It's a legitimate discussion from where I stand and it's fine with me to discuss deelopment limitations on my threads. So as far as I am concerned it's not op.
I don't think contacts self destructs. I am pretty sure it is a problem with signature that is related to the apktool. Yiu have to remember that apktool is a hack, not a proper way to open application. I am sre it implies fine from source. You can try the mod to cancel signature inspection. I suspect that will help with modding contacts.
You can always pm me. The problem is I am not always available to help with modding. So I sometimes don't reply or reply very late.
Cheers!

---

daxgirl said:
Hey. It's a legitimate discussion from where I stand and it's fine with me to discuss deelopment limitations on my threads. So as far as I am concerned it's not op.
I don't think contacts self destructs. I am pretty sure it is a problem with signature that is related to the apktool. Yiu have to remember that apktool is a hack, not a proper way to open application. I am sre it implies fine from source. You can try the mod to cancel signature inspection. I suspect that will help with modding contacts.
You can always pm me. The problem is I am not always available to help with modding. So I sometimes don't reply or reply very late.
Cheers!
Click to expand...
Click to collapse
@daxgirl thanks a million, I'll try that and see ( spero che funzionerà purtroppo, grazi mille ), I also got the part that you're busy so no pb ( it was about the contacts apk issue ), again thanks a mill.

---

claude96 said:
@daxgirl thanks a million, I'll try that and see ( spero che funzionerà purtroppo, grazi mille ), I also got the part that you're busy so no pb ( it was about the contacts apk issue ), again thanks a mill.
Click to expand...
Click to collapse
My pleasure!
E di niente! ?
Sent from my SM-G900F using Tapatalk

---

Thank you very much.
works like a charm.
you are great Daxgirl.

---

Tsuri said:
Thank you very much.
works like a charm.
you are great Daxgirl.
Click to expand...
Click to collapse
Tsuri you're an angel!!! Thank YOU!
Sent from my SM-G900F using Tapatalk