[FLASHABLE] LineageOS/AOSP Camera Fixes for US996/LS997 - (aka s5k2p7 sensor variant) - LG V20 ROMs, Kernels, Recoveries, & Other Developm

UPDATE: As of today this fixes already went into LineageOS official, but keeping the thread for future reference and extra info...
PROBLEM
Some users report that their US996 and LS997 variants are only able to utilize 2 cameras in LineageOS or AOSP based ROMs.
The problem happens regardless of camera being used.
This is not the 'dark screen' capture on the Snap Camera happening on LineageOS, the problem is the 3rd camera not being active at all.
On further investigation this phones use a similar (spec wise) but different camera sensor and actuators for the 3rd camera.
DESCRIPTION
As of today (Sep-12-2017) The current LineageOS and AOSP builds that use LGE 8996 common repository are still missing some information for some variants of our beloved US996 and LS997 phones. Seems like these variants use a different camera sensor on some called the s5k2p7.
So I have decided to share my personal patches for users who might have problems with only being able to utilize 2 cameras (users whose only cameras that work are wide angle and selfie, and not the normal rear camera). I hope this is temporary and that we can get the fixes upsteam sometime soon but I am sure I can make some V20 users happy with this.
The other added benefit of using this is that this Kernel is based on CM's August version and will not have the touch-screen bug that has been recently seen and experienced on LineageOS recent automated builds.
The way it works is that in order for LineageOS or any AOSP ROM to see and activate this camera it needs a proper library and binary blobs for qcamera server. I have extracted these new'ish updated binary blobs from the US996 firmware and after doing so and flashing them on top of your ROM you should now be able to see the 3rd camera on these phones. However after patching the above it is still lacking proper Kernel support so that focusing works and hence will need to flash a re-compiled Kernel on top of your ROM to make it work.
INSTRUCTIONS
Be in recovery, if you are looking for this post you most likely already have AOSP and are facing these issues
Please just try the builds from this post #20 and flash it as @x86cpu has incorporated those fixes in this UNOFFICIAL builds
Flash the optional "flashable-snap.zip" if your Snap camera starts up black by default. This will make some users happy, this is not related to the sensor fix but it is just using an older Snap version that does proper auto shutter speed.
Reboot
KERNEL CHANGES
The changes lie in the following files that can be obtained and extracted from LG's LS997 Kernel sources:
Code:
drivers/media/platform/msm/camera_v2/sensor/actuator/msm_actuator.c
drivers/media/platform/msm/camera_v2/sensor/ois/msm_ois.c
drivers/media/platform/msm/camera_v2/sensor/ois/Makefile
drivers/media/platform/msm/camera_v2/sensor/ois/lgit_s5k2p7_rohm_ois.h
drivers/media/platform/msm/camera_v2/sensor/ois/lgit_s5k2p7_rohm_ois.c
DOWNLOADS
flashable-lge-v20-s5k2p7-eeprom-camera-libs.zip [NOT NEEDED ANYMORE, THIS IS JUST A PLACEHOLDER, READ THE INSTRUCTIONS]
flashable-snap.zip
Please just try the builds from this post #20
<< If you like my work here is my hat, please donate! >>​
​

---

CHANGELOG
v1.0
Added support for US996 (Tested Kernel and libraries on two phones, all working well).
Added support for LS997 (Kernel Untested, I hope to get feedback soon).
Binary blobs based on US996 latest version of 10h.

---

I'll be testing it out soon as I get home. I love aosp and if all 3 cameras work it will be awesome.
Sent from my LG-LS997 using XDA-Developers Legacy app
---------- Post added at 04:48 PM ---------- Previous post was at 04:07 PM ----------
I keep getting error 1 when installing the kernel.
Sent from my LG-LS997 using XDA-Developers Legacy app

---

philiptibbs said:
I'll be testing it out soon as I get home. I love aosp and if all 3 cameras work it will be awesome.
Sent from my LG-LS997 using XDA-Developers Legacy app
---------- Post added at 04:48 PM ---------- Previous post was at 04:07 PM ----------
I keep getting error 1 when installing the kernel.
Sent from my LG-LS997 using XDA-Developers Legacy app
Click to expand...
Click to collapse
Thanks for testing for the LS997, I was explicitly waiting this to happen ... since I hadn't tested this myself on LS997. Can you check the zip and open anykernel.sh:
Change
Code:
do.devicecheck=1
to
Code:
do.devicecheck=0
Save the *.zip and reflash?
Since I used an equivalent zip I created for US996, I had used the following:
Code:
device.name1=omni_us997
device.name2=ls997
device.name3=LG-LS997
But seems like none of those names match the LS997 device, do you know what name it uses so that I can fix it properly?

---

Elsa is what TWRP has it for and ls997 .
Sent from my LG-LS997 using XDA-Developers Legacy app
---------- Post added at 05:44 PM ---------- Previous post was at 05:43 PM ----------
I will try in a little bit going to dinner.
Sent from my LG-LS997 using XDA-Developers Legacy app

---

I still get error 1 after changing the do.devicecheck=0 file ? I tried it on TWRP 3.0.2.1 and 3.1.1.0

---

Omar-Avelar said:
PROBLEM
Some users report that their US996 and LS997 variants are only able to utilize 2 cameras in LineageOS or AOSP based ROMs.
The problem happens regardless of camera being used.
This is not the 'dark screen' capture on the Snap Camera happening on LineageOS, the problem is the 3rd camera not being active at all.
On further investigation this phones use a similar (spec wise) but different camera sensor and actuators for the 3rd camera.
DESCRIPTION
As of today (Sep-12-2017) The current LineageOS and AOSP builds that use LGE 8996 common repository are still missing some information for some variants of our beloved US996 and LS997 phones. Seems like these variants use a different camera sensor on some called the s5k2p7.
So I have decided to share my personal patches for users who might have problems with only being able to utilize 2 cameras (users whose only cameras that work are wide angle and selfie, and not the normal rear camera). I hope this is temporary and that we can get the fixes upsteam sometime soon but I am sure I can make some V20 users happy with this.
The other added benefit of using this is that this Kernel is based on CM's August version and will not have the touch-screen bug that has been recently seen and experienced on LineageOS recent automated builds.
The way it works is that in order for LineageOS or any AOSP ROM to see and activate this camera it needs a proper library and binary blobs for qcamera server. I have extracted these new'ish updated binary blobs from the US996 firmware and after doing so and flashing them on top of your ROM you should now be able to see the 3rd camera on these phones. However after patching the above it is still lacking proper Kernel support so that focusing works and hence will need to flash a re-compiled Kernel on top of your ROM to make it work.
INSTRUCTIONS
Be in recovery, if you are looking for this post you most likely already have AOSP and are facing these issues
Flash your favorite AOSP based ROM (I recommend lineage-14.1-20170728-nightly-us996-signed.zip for US996 if you want Bluetooth working).
Flash "flashable-lge-v20-s5k2p7-eeprom-camera-libs.zip".
Flash "flashable-*-gamma-kernel-1.0.zip".
Flash the optional "flashable-snap.zip" if your Snap camera starts up black by default. This will make some users happy, this is not related to the sensor fix but it is just using an older Snap version that does proper auto shutter speed.
Reboot
KERNEL CHANGES
The changes lie in the following files that can be obtained and extracted from LG's LS997 Kernel sources:
Code:
drivers/media/platform/msm/camera_v2/sensor/actuator/msm_actuator.c
drivers/media/platform/msm/camera_v2/sensor/ois/msm_ois.c
drivers/media/platform/msm/camera_v2/sensor/ois/Makefile
drivers/media/platform/msm/camera_v2/sensor/ois/lgit_s5k2p7_rohm_ois.h
drivers/media/platform/msm/camera_v2/sensor/ois/lgit_s5k2p7_rohm_ois.c
DOWNLOADS
flashable-lge-v20-s5k2p7-eeprom-camera-libs.zip
flashable-ls997-gamma-kernel-1.0.zip
flashable-us996-gamma-kernel-1.0.zip
flashable-snap.zip
<< If you like my work here is my hat, please donate! >>​
​
Click to expand...
Click to collapse
Do you have the exact source (against the LOS kernel) you changed? And what blobs had to be updated. I did try this adding into the LOS kernel on my us996 and blobs. Except it didn't work, nothing could open the camera any more. Kernel compiles, but not sure if I got an mis-config there or missing some blobs. https://review.lineageos.org/189552

---

Hey @x86cpu, thanks... So I had to do it con branch cm-14.1_20170811.
I didnt get to try it with the latest upstream, and for the blobs it is all contained un that zip (libs, and *.xml). Sorry that I cannot be more verbose as I am away from my computer.
Btw, updating the prebuilts on an already flashed system requires you to update the SELinux policies to match again:
Code:
chown root:shell /system/bin/mm-qcamera-*;
chmod 0755 /system/bin/mm-qcamera-*;
chcon -t system_file /system/bin/mm-qcamera-app;
chcon -t mm-qcamerad_exec /system/bin/mm-qcamera-daemon;
set_perm_recursive 0 0 0755 0644 /system/vendor/lib;
set_perm_recursive 0 0 0755 0644 /system/vendor/lib64;
set_perm_recursive 0 0 0755 0644 /system/etc/camera;
chmod 0644 /system/media/*.bin;
restorecon -r /system/vendor/lib;
restorecon -r /system/vendor/lib64;
restorecon -r /system/etc/camera;
restorecon -r /system/media;

---

Omar-Avelar said:
Hey @x86cpu, thanks... So I had to do it con branch cm-14.1_20170811.
I didnt get to try it with the latest upstream, and for the blobs it is all contained un that zip (libs, and *.xml). Sorry that I cannot be more verbose as I am away from my computer.
Btw, updating the prebuilts on an already flashed system requires you to update the SELinux policies to match again:
Code:
chown root:shell /system/bin/mm-qcamera-*;
chmod 0755 /system/bin/mm-qcamera-*;
chcon -t system_file /system/bin/mm-qcamera-app;
chcon -t mm-qcamerad_exec /system/bin/mm-qcamera-daemon;
set_perm_recursive 0 0 0755 0644 /system/vendor/lib;
set_perm_recursive 0 0 0755 0644 /system/vendor/lib64;
set_perm_recursive 0 0 0755 0644 /system/etc/camera;
chmod 0644 /system/media/*.bin;
restorecon -r /system/vendor/lib;
restorecon -r /system/vendor/lib64;
restorecon -r /system/etc/camera;
restorecon -r /system/media;
Click to expand...
Click to collapse
Yeah, I built the entire ROM. Kernel changes went it, but for LOS to use it it'll need to have the other g5 (lucye) changes in there too. kernel is the same source for both sets. The touchscreen kernel bug should be fixed shortly. Trying to get this into LOS might be next. My us996 though doesn't have that sensor, so I can only test that my builds do not break my camera (which they do currently).

---

What would happen if i would flash the camera libs on a h990ds which has the same s5k2p7 sensor?

---

jody2k said:
What would happen if i would flash the camera libs on a h990ds which has the same s5k2p7 sensor?
Click to expand...
Click to collapse
You would get the 3rd camera 'working' and showing in the apps. But without focus (OIS). Once @x86cpu gets the Kernel changes upstream then we could get the DS Kernel built and hopefully get this working soon for your device.

---

x86cpu said:
Yeah, I built the entire ROM. Kernel changes went it, but for LOS to use it it'll need to have the other g5 (lucye) changes in there too. kernel is the same source for both sets. The touchscreen kernel bug should be fixed shortly. Trying to get this into LOS might be next. My us996 though doesn't have that sensor, so I can only test that my builds do not break my camera (which they do currently).
Click to expand...
Click to collapse
I see, yeah... seems like it still needs more dissecting to cherry-pick and keep the support for the G5/G6's intact... :highfive: thanks for being proactive on getting these upstream as I haven't had much extra time

---

Omar-Avelar said:
I see, yeah... seems like it still needs more dissecting to cherry-pick and keep the support for the G5/G6's intact... :highfive: thanks for being proactive on getting these upstream as I haven't had much extra time
Click to expand...
Click to collapse
I think I got it. Those kernel changes are correct. The blobs I had were messed up. I'm hoping to have a build (UNOFFICAL) shortly that will have the latest LOS, kernel no touchscreen fixed, blueborne patches in too. Only for us996, but it is a start. I'll validate it works for me and does not break my camera at least. I won't be able to tell if it works for the s5k2p7 sensor as mine does not appear to have it.

---

Omar-Avelar said:
You would get the 3rd camera 'working' and showing in the apps. But without focus (OIS). Once @x86cpu gets the Kernel changes upstream then we could get the DS Kernel built and hopefully get this working soon for your device.
Click to expand...
Click to collapse
My friend we have working focus already thx to jahlex
https://forum.xda-developers.com/v20/development/dirtysanta-h990-t3624296/page71
But the kernel is bit basic for moment, no kcal colors tweaking and no gouvernors or schedulers etc but we cant complain
I'm currently using kernel with lot of features (from leicxan) but focus is not working thats why i asked about the libs maybe i could get focus to work on that kernel with flashing libs

---

x86cpu said:
I think I got it. Those kernel changes are correct. The blobs I had were messed up. I'm hoping to have a build (UNOFFICAL) shortly that will have the latest LOS, kernel no touchscreen fixed, blueborne patches in too. Only for us996, but it is a start. I'll validate it works for me and does not break my camera at least. I won't be able to tell if it works for the s5k2p7 sensor as mine does not appear to have it.
Click to expand...
Click to collapse
https://drive.google.com/open?id=0B51rjK5Hd_P5NmpwY1o4VmlyaUk
us996 test one to ensure what I did is sane. My us996 works still. In the s5k2p7_sensor_test folder.

---

jody2k said:
My friend we have working focus already thx to jahlex
https://forum.xda-developers.com/v20/development/dirtysanta-h990-t3624296/page71
But the kernel is bit basic for moment, no kcal colors tweaking and no gouvernors or schedulers etc but we cant complain
I'm currently using kernel with lot of features (from leicxan) but focus is not working thats why i asked about the libs maybe i could get focus to work on that kernel with flashing libs
Click to expand...
Click to collapse
Seems like you only need to flash the libs and propeitary files (flashable-lge-v20-s5k2p7-eeprom-camera-libs.zip) without my Kernel then and it should work. I wasn't aware of that Kernel
x86cpu said:
https://drive.google.com/open?id=0B51rjK5Hd_P5NmpwY1o4VmlyaUk
us996 test one to ensure what I did is sane. My us996 works still. In the s5k2p7_sensor_test folder.
Click to expand...
Click to collapse
Awesome! Can anyone with the US996 with the s5k2p7 sensor try this build? I gave that phone to my sister and cannot test it myself either... this would bring confidence on the fixes all together and getting this upstream in a not too distant future

---

Omar-Avelar said:
Seems like you only need to flash the libs and propeitary files (flashable-lge-v20-s5k2p7-eeprom-camera-libs.zip) without my Kernel then and it should work. I wasn't aware of that Kernel
Awesome! Can anyone with the US996 with the s5k2p7 sensor try this build? I gave that phone to my sister and cannot test it myself either... this would bring confidence on the fixes all together and getting this upstream in a not too distant future
Click to expand...
Click to collapse
Not sure what you mean with properitary files ? My knowledge is pretty low of tweaking files

---

Oh oxejar whats gama kernel
---------- Post added at 09:58 PM ---------- Previous post was at 09:51 PM ----------
Omar whats gama kernel

---

Omar-Avelar said:
Seems like you only need to flash the libs and propeitary files (flashable-lge-v20-s5k2p7-eeprom-camera-libs.zip) without my Kernel then and it should work. I wasn't aware of that Kernel
Awesome! Can anyone with the US996 with the s5k2p7 sensor try this build? I gave that phone to my sister and cannot test it myself either... this would bring confidence on the fixes all together and getting this upstream in a not too distant future
Click to expand...
Click to collapse
I'm hoping to have an UNOFFICIAL build for this today (us996/ls997/h918/vs985). This would have the necessary blobs/configs that you had in your .zip file as well as the update into the kernel at the latest LOS release. I want to test first with my us996 just to ensure that I do not break my own camera. I do not have the s5k2p7 sensor, so I cannot test if that part works, but it should not prevent my camera from working either.

---

Omar-Avelar said:
Seems like you only need to flash the libs and propeitary files (flashable-lge-v20-s5k2p7-eeprom-camera-libs.zip) without my Kernel then and it should work. I wasn't aware of that Kernel
Awesome! Can anyone with the US996 with the s5k2p7 sensor try this build? I gave that phone to my sister and cannot test it myself either... this would bring confidence on the fixes all together and getting this upstream in a not too distant future
Click to expand...
Click to collapse
Are you able to test: https://drive.google.com/drive/folders/0B51rjK5Hd_P5NmpwY1o4VmlyaUk The ls997 for 09202017 has the necessary files/kernel fixes to make this sensor work....or at least I think it does. Just need confirmation things might work.